[Artist] DTO 스키마 추가 및 ArtistType ENUM 변경 by ys0221 · Pull Request #85 · prgrms-web-devcourse-final-project/WEB7_9_codecrete_BE

ys0221 · 2025-12-16T02:30:45Z

🔗 관련 이슈

관련된 이슈 번호를 연결해주세요.
Close #이슈번호 를 쓰면 PR merge 시 자동으로 close 됩니다.

Close [Artist] DTO 스키마 추가 및 ArtistType ENUM 변경 #82

🚀 PR 개요

이 PR이 어떤 변경을 포함하고 있는지 간단히 설명해주세요.

아티스트 도메인 리팩토링

DTO(CreateRequest, UpdateRequest) 스키마 추가
ArtistType : 기존 String 에서 ENUM 으로 변경

📌 변경 사항

주요 변경 내용을 체크리스트 형태로 정리해주세요.

🧪 테스트 방법

변경된 내용을 어떻게 테스트했는지 구체적으로 적어주세요.

📸 스크린샷 (선택)

UI 변경 또는 시각적으로 확인할 수 있는 변경이 있다면 첨부해주세요.

⚠️ 참고 사항

리뷰어가 알아야 할 사항이 있다면 자유롭게 작성해주세요.

github-actions · 2025-12-16T02:32:31Z

Test Results

1 tests ±0 1 ✅ ±0 0s ⏱️ ±0s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 8d44971. ± Comparison against base commit 697d54e.

github-actions · 2025-12-16T02:32:49Z

⭐ JaCoCo Coverage

Line Coverage: 5.78%

📄 Coverage Details

Overall Line Coverage: 5.75% (122 covered / 2122 lines)

Package Summary (lowest first)

Package	Line %	Covered	Missed
`com/back/web7_9_codecrete_be/domain/chats/controller`	0.00%	0	0
`com/back/web7_9_codecrete_be/domain/location/service`	0.00%	0	25
`com/back/web7_9_codecrete_be/domain/chats/service`	0.00%	0	0
`com/back/web7_9_codecrete_be/domain/plans/controller`	0.00%	0	33
`com/back/web7_9_codecrete_be/domain/location/controller`	0.00%	0	4
`com/back/web7_9_codecrete_be/global/rsData`	0.00%	0	11
`com/back/web7_9_codecrete_be/domain/location/entity`	0.00%	0	0
`com/back/web7_9_codecrete_be/global/scheduler`	0.00%	0	3
`com/back/web7_9_codecrete_be/domain/auth/entity`	0.00%	0	0
`com/back/web7_9_codecrete_be/domain/auth/service`	0.00%	0	71
`com/back/web7_9_codecrete_be/domain/plans/service`	0.00%	0	311
`com/back/web7_9_codecrete_be/global/initData`	0.00%	0	26
`com/back/web7_9_codecrete_be/domain/users/controller`	0.00%	0	20
`com/back/web7_9_codecrete_be/domain/email/entity`	0.00%	0	6
`com/back/web7_9_codecrete_be/domain/users/service`	0.00%	0	59
`com/back/web7_9_codecrete_be/domain/auth/controller`	0.00%	0	20
`com/back/web7_9_codecrete_be/domain/concerts/controller`	0.00%	0	22
`com/back/web7_9_codecrete_be/domain/artists/controller`	0.00%	0	12
`com/back/web7_9_codecrete_be/global/aspect`	0.00%	0	4
`com/back/web7_9_codecrete_be/global/wikidata`	0.36%	1	279
`com/back/web7_9_codecrete_be/domain/artists/service`	0.84%	3	354
`com/back/web7_9_codecrete_be/global/musicbrainz`	0.99%	1	100
`com/back/web7_9_codecrete_be/domain/email/service`	1.92%	1	51
`com/back/web7_9_codecrete_be/domain/concerts/entity`	4.76%	3	60
`com/back/web7_9_codecrete_be/domain/concerts/service`	6.80%	21	288
`com/back/web7_9_codecrete_be/global/rq`	12.90%	4	27
`com/back/web7_9_codecrete_be/domain/artists/entity`	16.67%	6	30
`com/back/web7_9_codecrete_be/domain/users/entity`	22.86%	8	27
`com/back/web7_9_codecrete_be/domain/plans/entity`	24.42%	21	65
`com/back/web7_9_codecrete_be/global/security`	26.36%	29	81
`com/back/web7_9_codecrete_be/global/storage`	33.33%	1	2
`com/back/web7_9_codecrete_be/global/spotify`	35.71%	5	9
`com/back/web7_9_codecrete_be/domain/chats/entity`	100.00%	1	0
`com/back/web7_9_codecrete_be/global/doc`	100.00%	17	0

Lowest Covered Classes (Top 20)

Class	Line %	Missed
`com.back.web7_9_codecrete_be.domain.plans.service.PlanService`	0.00%	311
`com.back.web7_9_codecrete_be.domain.users.service.UserService`	0.00%	55
`com.back.web7_9_codecrete_be.domain.concerts.service.ConcertService`	0.00%	48
`com.back.web7_9_codecrete_be.domain.auth.service.AuthService`	0.00%	44
`com.back.web7_9_codecrete_be.domain.artists.service.ArtistService`	0.00%	44
`com.back.web7_9_codecrete_be.domain.concerts.entity.Concert`	0.00%	38
`com.back.web7_9_codecrete_be.global.security.JwtTokenProvider`	0.00%	37
`com.back.web7_9_codecrete_be.domain.plans.entity.Schedule`	0.00%	36
`com.back.web7_9_codecrete_be.domain.plans.controller.PlanController`	0.00%	33
`com.back.web7_9_codecrete_be.domain.users.entity.User`	0.00%	27
`com.back.web7_9_codecrete_be.domain.auth.service.TokenService`	0.00%	27
`com.back.web7_9_codecrete_be.global.initData.BaseInitData`	0.00%	26
`com.back.web7_9_codecrete_be.domain.artists.entity.Artist`	0.00%	25
`com.back.web7_9_codecrete_be.domain.users.controller.UserController`	0.00%	20
`com.back.web7_9_codecrete_be.domain.auth.controller.AuthController`	0.00%	20
`com.back.web7_9_codecrete_be.domain.plans.entity.Plan`	0.00%	18
`com.back.web7_9_codecrete_be.domain.concerts.controller.ConcertController`	0.00%	14
`com.back.web7_9_codecrete_be.domain.location.service.TmapService`	0.00%	13
`com.back.web7_9_codecrete_be.domain.concerts.service.KopisApiService$TicketPrice`	0.00%	13
`com.back.web7_9_codecrete_be.domain.location.service.KakaoLocalService`	0.00%	12

Changed Classes (from this PR)

Source (PR)	Class Prefix	Line %	Covered	Missed
`src/main/java/com/back/web7_9_codecrete_be/domain/artists/service/ArtistService.java`	`com.back.web7_9_codecrete_be.domain.artists.service.ArtistService`	0.00%	0	44
`src/main/java/com/back/web7_9_codecrete_be/domain/artists/controller/ArtistsController.java`	`com.back.web7_9_codecrete_be.domain.artists.controller.ArtistsController`	0.00%	0	12
`src/main/java/com/back/web7_9_codecrete_be/domain/artists/dto/request/CreateRequest.java`	`com.back.web7_9_codecrete_be.domain.artists.dto.request.CreateRequest`	0.00%	0	0
`src/main/java/com/back/web7_9_codecrete_be/domain/artists/dto/request/UpdateRequest.java`	`com.back.web7_9_codecrete_be.domain.artists.dto.request.UpdateRequest`	0.00%	0	0
`src/main/java/com/back/web7_9_codecrete_be/domain/artists/dto/response/ArtistDetailResponse.java`	`com.back.web7_9_codecrete_be.domain.artists.dto.response.ArtistDetailResponse`	0.00%	0	0
`src/main/java/com/back/web7_9_codecrete_be/domain/artists/service/ArtistEnrichService.java`	`com.back.web7_9_codecrete_be.domain.artists.service.ArtistEnrichService`	0.81%	1	123
`src/main/java/com/back/web7_9_codecrete_be/domain/artists/service/SpotifyService.java`	`com.back.web7_9_codecrete_be.domain.artists.service.SpotifyService`	1.08%	2	183
`src/main/java/com/back/web7_9_codecrete_be/domain/artists/entity/Artist.java`	`com.back.web7_9_codecrete_be.domain.artists.entity.Artist`	13.79%	4	25
`src/main/java/com/back/web7_9_codecrete_be/domain/artists/entity/ArtistType.java`	`com.back.web7_9_codecrete_be.domain.artists.entity.ArtistType`	100.00%	3	0

🔗 Full HTML report: See artifact jacoco-full-html on this run → https://github.com/prgrms-web-devcourse-final-project/WEB7_9_codecrete_BE/actions/runs/20254459852

larama-C

수고하셨습니다. 풀path 부분 멘토링 질문하셔도 좋을 것 같아요

larama-C · 2025-12-16T08:07:15Z

            SpotifyApi api = spotifyClient.getAuthorizedApi();

-            Artist artist = api.getArtist(spotifyArtistId).build().execute(); // 메인 정보는 실패 시 예외 발생
+            se.michaelthelin.spotify.model_objects.specification.Artist artist = api.getArtist(spotifyArtistId).build().execute(); // 메인 정보는 실패 시 예외 발생


왜 풀path로 쓰시지 싶었는데 기존 artist엔티티랑 충돌이 나셔서 쓰는거였군요!

맞아요 ㅜ.ㅜ...

멘토링 때 질문 한 번 해보겠습니당

tobbot16

수고하셨습니다~

Creamcheesepie · 2025-12-16T08:13:01Z

수고하셨습니다.

ys0221 added 2 commits December 16, 2025 11:07

refactor : DTO 스키마 추가

7f47452

refactor : ArtistType -> ENUM 으로 변경

8d44971

ys0221 self-assigned this Dec 16, 2025

ys0221 added the Refactor label Dec 16, 2025

larama-C approved these changes Dec 16, 2025

View reviewed changes

tobbot16 approved these changes Dec 16, 2025

View reviewed changes

Creamcheesepie approved these changes Dec 16, 2025

View reviewed changes

Creamcheesepie merged commit a99e4c0 into main Dec 17, 2025
2 checks passed

Creamcheesepie deleted the feat/#82 branch December 17, 2025 00:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Artist] DTO 스키마 추가 및 ArtistType ENUM 변경#85

[Artist] DTO 스키마 추가 및 ArtistType ENUM 변경#85
Creamcheesepie merged 2 commits into
mainfrom
feat/#82

ys0221 commented Dec 16, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Dec 16, 2025

Uh oh!

github-actions Bot commented Dec 16, 2025

Uh oh!

larama-C left a comment

Uh oh!

larama-C Dec 16, 2025

Uh oh!

ys0221 Dec 16, 2025

Uh oh!

ys0221 Dec 16, 2025

Uh oh!

tobbot16 left a comment

Uh oh!

Creamcheesepie commented Dec 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ys0221 commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 관련 이슈

🚀 PR 개요

📌 변경 사항

🧪 테스트 방법

📸 스크린샷 (선택)

⚠️ 참고 사항

Uh oh!

github-actions Bot commented Dec 16, 2025

Test Results

Uh oh!

github-actions Bot commented Dec 16, 2025

⭐ JaCoCo Coverage

📄 Coverage Details

Uh oh!

larama-C left a comment

Choose a reason for hiding this comment

Uh oh!

larama-C Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

ys0221 Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

ys0221 Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

tobbot16 left a comment

Choose a reason for hiding this comment

Uh oh!

Creamcheesepie commented Dec 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ys0221 commented Dec 16, 2025 •

edited

Loading